Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web::uri::validate returns false on uri with "":"" in query #1628

Open
zamx opened this issue Jun 21, 2021 · 1 comment · May be fixed by #1632
Open

web::uri::validate returns false on uri with "":"" in query #1628

zamx opened this issue Jun 21, 2021 · 1 comment · May be fixed by #1632

Comments

@zamx
Copy link

zamx commented Jun 21, 2021

web::uri::validate() wrongly assumes uri foo?bar=foo:bar is a absolute path because of the ":" in the query. RFC-3986 allows queries to contain ":".
@garethsb
Copy link
Contributor

garethsb commented Jul 1, 2021

I think you're right, I believe your example is a valid relative-ref.

Per RFC 3986 section 4.2:

relative-ref  = relative-part [ "?" query ] [ "#" fragment ]

Therefore, probably

cpprestsdk/Release/src/uri/uri.cpp

Line 180 in bfe3487

for (; *p2 != _XPLATSTR('/') && *p2 != _XPLATSTR('\0'); p2++)

needs to also stop at ? or #...

An example like yours should be added to the test cases near relative_ref_string...

cpprestsdk/Release/tests/functional/uri/constructor_tests.cpp

Line 73 in bfe3487

TEST(relative_ref_string)

Edit: I now have a test case and fix, so I'll make a PR later.

@garethsb garethsb linked a pull request Jul 5, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix URI parsing to correctly disambiguate relative-ref garethsb/cpprestsdk
2 participants
@zamx @garethsb