Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Columns are excluded from the unformatted option when downloading #42500

Closed
Tony-metabase opened this issue May 10, 2024 · 0 comments · Fixed by #42543
Closed

Columns are excluded from the unformatted option when downloading #42500

Tony-metabase opened this issue May 10, 2024 · 0 comments · Fixed by #42543
Assignees
@adam-james-v
Labels
.Backend .Escalation Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Reporting/Export Type:Bug Product defects
Milestone
0.49.10

Comments

@Tony-metabase
Copy link
Contributor

Describe the bug

Columns are excluded form the formatted/unformatted option when downloading ... External systems are expecting an unformatted column which used to be downloaded before 48 differently when it does now in 49

To Reproduce

  1. Go to New -> Question -> Orders -> Save
  2. Go to Total Column -> Rename it to -> "This is a formatted column"
image
  1. Download the question using unformatted option, notice the name remains the same even though results themself change:
image

Expected behavior

If you download unformatted results then nothing should keep the formatting. Applies for Question, Dashboards and anywhere else we offer the unformatted option

Logs

Nothing that is relevant

Information about your Metabase installation

1.49.9 and master

Severity

Blocker since external systems are expecting an unformatted column which used to be downloaded before 48 differently when it does now in 49

Additional context

No response
@Tony-metabase Tony-metabase added Type:Bug Product defects Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Reporting/Export .Backend .Escalation labels May 10, 2024
@Tony-metabase Tony-metabase changed the title Columns are excluded form the formatted/unformatted option when downloading Columns are excluded from the unformatted option when downloading May 10, 2024
@adam-james-v adam-james-v self-assigned this May 10, 2024
adam-james-v added a commit that referenced this issue May 10, 2024
@adam-james-v
Format Rows toggle also applies to Column Names
e1a58fa 
Fixes: #42500
When format-rows is false, we want to also pass that true/false value to the title column formatting.

That is, if a column is renamed and formatting is applied, we want to use that column's name. But, if a column is
renamed and the user exports unformatted csv or json, the custom column name should NOT be used, as was the behaviour
in prior versions.
@adam-james-v adam-james-v mentioned this issue May 10, 2024
Merged
adam-james-v added a commit that referenced this issue May 10, 2024
@adam-james-v
Format Rows toggle also applies to Column Names (#42543)
932781a 
* Format Rows toggle also applies to Column Names

Fixes: #42500
When format-rows is false, we want to also pass that true/false value to the title column formatting.

That is, if a column is renamed and formatting is applied, we want to use that column's name. But, if a column is
renamed and the user exports unformatted csv or json, the custom column name should NOT be used, as was the behaviour
in prior versions.

* write a better test explanation
github-actions bot pushed a commit that referenced this issue May 10, 2024
@adam-james-v
Format Rows toggle also applies to Column Names (#42543)
7608503 
* Format Rows toggle also applies to Column Names

Fixes: #42500
When format-rows is false, we want to also pass that true/false value to the title column formatting.

That is, if a column is renamed and formatting is applied, we want to use that column's name. But, if a column is
renamed and the user exports unformatted csv or json, the custom column name should NOT be used, as was the behaviour
in prior versions.

* write a better test explanation
@adam-james-v adam-james-v added this to the 0.49.10 milestone May 10, 2024
metabase-bot bot added a commit that referenced this issue May 11, 2024
@metabase-bot @adam-james-v
Format Rows toggle also applies to Column Names (#42543) (#42545)
708926f 
* Format Rows toggle also applies to Column Names

Fixes: #42500
When format-rows is false, we want to also pass that true/false value to the title column formatting.

That is, if a column is renamed and formatting is applied, we want to use that column's name. But, if a column is
renamed and the user exports unformatted csv or json, the custom column name should NOT be used, as was the behaviour
in prior versions.

* write a better test explanation

Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com>
uladzimirdev pushed a commit that referenced this issue May 11, 2024
@adam-james-v @uladzimirdev
Format Rows toggle also applies to Column Names (#42543)
8e72f29 
* Format Rows toggle also applies to Column Names

Fixes: #42500
When format-rows is false, we want to also pass that true/false value to the title column formatting.

That is, if a column is renamed and formatting is applied, we want to use that column's name. But, if a column is
renamed and the user exports unformatted csv or json, the custom column name should NOT be used, as was the behaviour
in prior versions.

* write a better test explanation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adam-james-v adam-james-v

Labels
.Backend .Escalation Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Reporting/Export Type:Bug Product defects
Projects
None yet
Milestone
0.49.10
Development

Successfully merging a pull request may close this issue.

Format Rows toggle also applies to Column Names metabase/metabase
2 participants
@adam-james-v @Tony-metabase