Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] [QP] Allow using compatible metrics for the source table #42462

Closed
2 tasks done
Tracked by #37335
ranquild opened this issue May 9, 2024 · 0 comments
Closed
2 tasks done
Tracked by #37335

[BE] [QP] Allow using compatible metrics for the source table #42462

ranquild opened this issue May 9, 2024 · 0 comments
Assignees
@snoe

Comments

@ranquild
Copy link
Contributor

ranquild commented May 9, 2024 •
edited by snoe

Support v1 behavior:

  • Return compatible metrics in /api/table/:id/query_metadata as before
  • Allow referencing compatible metrics in queries without joins (previous behavior)

Tasks
Beta Give feedback
  1. [BE] [QP] Allow referencing compatible metrics in queries without joins (previous behavior) #42667
    snoe
  2. [BE] [API] Return compatible metrics in /api/table/:id/query_metadata as before #42668
    snoe
@ranquild ranquild mentioned this issue May 9, 2024
Open
@snoe snoe self-assigned this May 9, 2024
@ranquild ranquild changed the title [BE] [QP, MBQL lib] Allow using compatible metrics for the source table [BE] [QP] Allow using compatible metrics for the source table May 9, 2024
@ranquild ranquild mentioned this issue May 9, 2024
Closed
snoe added a commit that referenced this issue May 14, 2024
@snoe
[Metrics V2] Query processor handle no join strategy
725bd48 
Fixes #42462

Make QP preprocessor handle queries referencing metrics in the style of
legacy metrics. Enforce various compatibility checks.
This was referenced May 14, 2024
Merged
Merged
snoe added a commit that referenced this issue May 16, 2024
@snoe
[Metrics V2] Query processor handle no join strategy (#42666)
a4e2903 
* [Metrics V2] Query processor handle no join strategy

Fixes #42462

Make QP preprocessor handle queries referencing metrics in the style of
legacy metrics. Enforce various compatibility checks.

* Make sure to adjust the actual stages being walked

* Address PR comments

* Add tests for recursion

* Fix e2e tests by setting fields on adjusted metric stage

* Fix more e2e tests by recurring properly
@snoe snoe closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snoe snoe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snoe @ranquild