Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated series in chart after filter is removed #42447

Open
zbodi74 opened this issue May 9, 2024 · 1 comment
Open

Duplicated series in chart after filter is removed #42447

zbodi74 opened this issue May 9, 2024 · 1 comment
Labels
.Frontend Priority:P2 Average run of the mill bug .Team/DashViz Dashboard and Viz team Type:Bug Product defects Visualization/Chart Settings Visualization/Charts Line, area, bar, combo, and scatter charts.

Comments

@zbodi74
Copy link

zbodi74 commented May 9, 2024

Describe the bug

Removing a post-aggregation filter causes duplication of data on a single series chart.

To Reproduce

  1. Create a GUI question: Orders, Summarize: Count of rows, Group by: Product --> Category
  2. Add filter post aggregation: Product --> Category is not empty
  3. Visualize: select Bar (or Row)
  4. Save it
  5. Edit the question and remove the filter
  6. The series is now duplicated, and the error persists if the question is saved.
image

Expected behavior

The duplication should not happen.

Logs

No response

Information about your Metabase installation

1.49.8

Severity

P1 or P2 - Reported by a customer. It seems to affect a common feature.

Additional context

I couldn't reproduce this on stats as of 2024-05-08 / 1c5e599 .

@zbodi74 zbodi74 added Type:Bug Product defects Priority:P2 Average run of the mill bug .Needs Triage Visualization/Charts Line, area, bar, combo, and scatter charts. labels May 9, 2024
@calherries
Copy link
Contributor

calherries commented May 9, 2024

This is an FE issue.

Following the steps above, at step 4 these are the visualization_settings of the card:

    "visualization_settings": {
        "graph.dimensions": [
            "CATEGORY"
        ],
        "graph.metrics": [
            "count"
        ]
    },

After saving at step 6, the visualization_settings have a duplicated count metric:

    "visualization_settings": {
        "graph.dimensions": [
            "CATEGORY"
        ],
        "graph.metrics": [
            "count",
            "count"
        ]
    },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P2 Average run of the mill bug .Team/DashViz Dashboard and Viz team Type:Bug Product defects Visualization/Chart Settings Visualization/Charts Line, area, bar, combo, and scatter charts.
Projects
None yet
Development

No branches or pull requests

2 participants