Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to remove Dbc prefix #89

Open
davidrusu opened this issue Sep 15, 2021 · 2 comments
Open

Rename to remove Dbc prefix #89

davidrusu opened this issue Sep 15, 2021 · 2 comments

Comments

@davidrusu
Copy link
Contributor

  1. DbcContent -> Content
  2. DbcTransaction -> Transaction
  3. etc.

Dbc here is superfluous.

@dan-da
Copy link
Contributor

dan-da commented Sep 15, 2021

Dbc here is superfluous

Is it? We have other types besides Dbc in the crate. in particular MintNode and it's associated types. All are present in same crate root namespace.

If we changed it so that one could only access via eg: dbc::{Content, Transaction}, then I think I would agree it is superfluous.

@davidrusu
Copy link
Contributor Author

A dbc module would be good, I'd be down with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants