Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize emojis from specific inputs #3032

Open
patrickrb opened this issue Mar 27, 2024 · 3 comments
Open

Sanitize emojis from specific inputs #3032

patrickrb opened this issue Mar 27, 2024 · 3 comments

Comments

@patrickrb
Copy link
Contributor

patrickrb commented Mar 27, 2024

  • You can enter emojis into some text inputs where we may not want them
  • I'm happy to knock this out, I feel like i can likely extend the security helper to add a function to sanitize inputs

Describe the bug

  • Users can insert emojis into text inputs that may not be desirable
  • Could this cause issues with LOTW/adif exports?
  • Should testing imports that have emojis in them?

To Reproduce
Steps to reproduce the behaviour:
Try to input an emoji in the QSO exchange

Expected behaviour
A user shouldnt be allowed to enter an emoji into some inputs, like QSO exchange

Screenshots
image of a QSO with emojis in the exchange

thanks to @gx1400 for suggesting I test emojis in that input

Copy link

Uh oh! @patrickrb, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

1 similar comment
Copy link

Uh oh! @patrickrb, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@patrickrb
Copy link
Contributor Author

Started a branch here, was able to get it sanitizing on the backend, but id like to catch it on the frontend too before PRing the change

https://github.com/patrickrb/Cloudlog/tree/3032-sanitize-inputs-from-emojis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant