Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command execution should be prevented by context #466

Open
2 tasks done
aniruddhas opened this issue Mar 24, 2024 · 2 comments
Open
2 tasks done

command execution should be prevented by context #466

aniruddhas opened this issue Mar 24, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@aniruddhas
Copy link

⚠️ Please verify that this bug has NOT been reported before.

  • I checked and didn't find similar issue

🛡️ Security Policy

Description

First of all, Thanks for this awesome project and great work!
You've implemented a superb feature to ensure security of the host. This is evident by allowing only these commands in console tab: "docker, ls, cd, dir"
Unfortunately, I ran into an issue when I executed "docker exec -it container sh"
I couldn't exit it, as it's prohibited.

👟 Reproduction steps

Download this dockge image as recommended:
louislam/dockge:1

  1. Import your containers/ let dockge manage your containers
  2. Try to use docker attach / exec shell to any container
  3. Try exiting.

👀 Expected behavior

exit command should be allowed in the context

😓 Actual Behavior

can't exit.

Dockge Version

1

💻 Operating System and Arch

Debian bullseye

🌐 Browser

Firefox Nightly

🐋 Docker Version

Docker 25

🟩 NodeJS Version

NA

📝 Relevant log output

NA
@aniruddhas aniruddhas added the bug Something isn't working label Mar 24, 2024
@aniruddhas
Copy link
Author

Screenshot_20240325_105016_Firefox Nightly

Had to restart the container to which I had attached from console.
If console has an option to kill current session, that should also suffice instead of getting into complicated contextualisation of commands.

@FireFingers21
Copy link

There are also issues with other commands like docker image prune where the shell asks for confirmation with "Are you sure you want to continue? [y/N]". Typing y or n isn't allowed so you're essentially stuck unless you Ctrl+C to abort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants