Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CommonMarker #1234

Open
pushcx opened this issue Dec 29, 2023 · 1 comment
Open

Update CommonMarker #1234

pushcx opened this issue Dec 29, 2023 · 1 comment

Comments

@pushcx
Copy link
Member

pushcx commented Dec 29, 2023

We’re on a years-old version of CommonMarker. It’s changed its API, dropping a method we used in extras/markdowner.rb to add attributes to links, rewrite some HTML, and make the @username feature work. (Heck, they even renamed their constant from CommonMarker to Commonmarker.)

That issue links to a gem they suggest, but perhaps we should just expand our use of Nokogiri? Or maybe there’s a very different way to tie into the renderer at the time it’s emitting HTML, which I’d be more confident in than re-parsing and fixing things up externally. So this one requires some technical investigation!

pushcx added a commit that referenced this issue Dec 29, 2023
lot of irritating churn out of standardrb here
@pushcx
Copy link
Member Author

pushcx commented May 20, 2024

I'm not sure the check that a user exists is worthwhile given that users can change their usernames pretty freely.

Maybe our username linking can become an extension to have a more stable API?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant