Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False validation errors on charts with custom dimensions #10122

Closed
joaoviana opened this issue May 20, 2024 · 1 comment · Fixed by #10121
Closed

False validation errors on charts with custom dimensions #10122

joaoviana opened this issue May 20, 2024 · 1 comment · Fixed by #10121
Assignees
@joaoviana
Labels
🐛 bug Something isn't working as expected. This can be an error or an unexpected user experience released

Comments

@joaoviana
Copy link
Contributor

Description

Now that metricQuery.dimensions includes custom dimensions we are throwing validation errors for missing custom dimensions because we're not using the correct list to check these against

Steps to Reproduce the Bug or Issue

  1. Add custom dimensions to Chart
  2. Run validator
  3. See false errors

version

No response

Cloud or self-hosting

cloud
@joaoviana joaoviana added the 🐛 bug Something isn't working as expected. This can be an error or an unexpected user experience label May 20, 2024
@joaoviana joaoviana assigned joaoviana and unassigned joaoviana May 20, 2024
@joaoviana joaoviana mentioned this issue May 20, 2024
Merged
3 tasks
@lightdash-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 0.1099.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaoviana joaoviana

Labels
🐛 bug Something isn't working as expected. This can be an error or an unexpected user experience released
Projects
Selected for Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: validate custom dimensions if field is custom dim lightdash/lightdash
2 participants
@joaoviana @lightdash-bot