-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix brew path on Apple Silicon #1633
Conversation
@@ -583,7 +580,7 @@ jobs: | |||
else | |||
EVENT_CMAKE_OPTIONS="" | |||
fi | |||
EVENT_CMAKE_OPTIONS="$EVENT_CMAKE_OPTIONS -DMBEDTLS_ROOT_DIR=/usr/local/opt/mbedtls@2" | |||
EVENT_CMAKE_OPTIONS="$EVENT_CMAKE_OPTIONS -DMBEDTLS_ROOT_DIR=`brew --prefix mbedtls@2`" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW what is @2
can we adopt the detection that we have in cmake as well? (can be done separately)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW what is
@2
The @2
forces the version 2 instead of version 3. It was added by #1204.
If we remove it, then we would be using mbedtls 3 instead of mbedtls 2. Yes, can be updated in a separate PR.
can we adopt the detection that we have in cmake as well?
Maybe. But also for a separate PR.
Fix #1632