Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note attachment changes not reflected after reducing them #10403

Open
stavpup opened this issue May 6, 2024 · 1 comment
Open

Note attachment changes not reflected after reducing them #10403

stavpup opened this issue May 6, 2024 · 1 comment
Labels
backlog We'll get to it... eventually... bug It's a bug desktop All desktop platforms

Comments

@stavpup
Copy link

stavpup commented May 6, 2024

Operating system

Windows

Joplin version

2.14.20

Desktop version info

2.14.20

Current behaviour

One can check for the largest attachments at windows client by Tools -> Note attachments... -> Sort by size. Also from there it is possible to edit that image with external editor and reduce file size.

Expected behaviour

When visiting back note attachments, the changes on the big files are not updated, and it shows the files with their original size

Logs

No response

@stavpup stavpup added the bug It's a bug label May 6, 2024
@personalizedrefrigerator personalizedrefrigerator added desktop All desktop platforms backlog We'll get to it... eventually... labels May 23, 2024
@personalizedrefrigerator
Copy link
Collaborator

For reference, the code responsible for displaying the size of an attachment can be found here:

<td style={cellStyle} className="dataCell">{prettyBytes(resource.size)}</td>

It might also be necessary to use the ResourceEditWatcher to watch resources for changes and update the size on resourceChange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We'll get to it... eventually... bug It's a bug desktop All desktop platforms
Projects
None yet
Development

No branches or pull requests

2 participants