Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some forms are .txt only and web UI wants .html? #325

Open
n2ygk opened this issue Feb 19, 2022 · 9 comments
Open

Some forms are .txt only and web UI wants .html? #325

n2ygk opened this issue Feb 19, 2022 · 9 comments
Labels
bug forms templates

Comments

@n2ygk
Copy link
Contributor

n2ygk commented Feb 19, 2022

When I try to compose via http interface the template MAPPPING-GIS FORMS/Local Weather Report I get a not found error for http://127.0.0.1:8080/api/forms?formPath=MAPPING-GIS%20FORMS%2FLocal%20Weather%20Report.html.

Looking in the templates directory, I see that these forms are only available as .txt files. I'm not sure if the missing HTML files are a pat or a Winlink issue (since there's a perfectly fine HTML local weather form in WEATHER FORMS).

(Pat is really nice! Finally some amateur UI software that doesn't require Windows.)
@martinhpedersen
Copy link
Member

I guess we only support HTML forms now? (@xylo04)

If so, I think we should mark those forma as unsupported in the UI or at least give a better error message.

Let's call this a bug 🙂

@n2ygk
Copy link
Contributor Author

n2ygk commented Feb 23, 2022

Or

(echo '<HTML><PRE>'; cat file.txt; echo '</PRE></HTML>)'

😃

@martinhpedersen
Copy link
Member

Would that work? 😁

@martinhpedersen
Copy link
Member

... if so, we can easily add a fallback wrapping txt-only forms when serving them to the web client 🙂

@martinhpedersen
Copy link
Member

martinhpedersen commented Feb 23, 2022 •
edited

.. the details are starting to come back to me. IIRC, the html contains logic to accept user input. So we would need to generate that as well.

@n2ygk
Copy link
Contributor Author

n2ygk commented Feb 23, 2022 via email

@xylo04
Copy link
Contributor

xylo04 commented Mar 11, 2022

I'll add, myself and at least a few other users are following Winlink Thursday exercises, and this week's challenge was to download a text-only form and put it into WLE's Private Templates. Well, this issue is preventing use of text only forms, plus Pat doesn't really have a Private Templates directory yet. So this was a reminder to keep widening our feature set! 👍

@drboone
Copy link

drboone commented Mar 26, 2022

The FEMA R5AN net this week wants 'Winlink Check In', which is .txt only.

@xylo04
Copy link
Contributor

xylo04 commented Jun 17, 2022 •
edited

This one is interesting: this week's ETO Winlink Thursday calls for "Mapping-GIS Forms" "Hospital Bed Report." At the current forms version 1.0.198, that one only has a text file, but the first line of the template references HTML files:

Form: Hospital_Bed_Report_Initial.html,Hospital_Bed_Report_Viewer.html

Those files are not found in the MAPPING-GIS FORMS directory:

Standard_Forms $  find . -name "Hospital_Bed_Report_Initial*"
./GENERAL Forms/Hospital_Bed_Report_Initial.html
./GENERAL MEDICAL Forms/Hospital_Bed_Report_Initial.html

So the search path for finding referenced files is not just the same directory.

@martinhpedersen martinhpedersen mentioned this issue Feb 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug forms templates
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@drboone @xylo04 @martinhpedersen @n2ygk