Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full screen editing experience #4040

Open
aabedraba opened this issue Jun 5, 2023 · 10 comments
Open

Full screen editing experience #4040

aabedraba opened this issue Jun 5, 2023 · 10 comments
Assignees
Labels
good first issue Good for newcomers ux-ready The functionality is ready to be implemented

Comments

@aabedraba
Copy link

At the moment Monokle limits me to the right tab section for editing.

I would love to be able to have a full screen "focus mode" experience for editing my files instead of the same real estate assigned to it:

CleanShot 2023-06-05 at 11 56 05

@devcatalin devcatalin added the good first issue Good for newcomers label Jun 6, 2023
@devcatalin
Copy link
Member

devcatalin commented Jun 6, 2023

@ayushgml this could be another issue to work on if you'd like

@ayushgml
Copy link
Contributor

ayushgml commented Jun 6, 2023

Yes i can work this issue too! Thanks @devcatalin!

@julioramosest
Copy link

@ayushgml expect some design for this tomorrow morning CET time. I had UI work for quickly expanding the editor in the IDE view - but needs some adjusting for the cluster mode.

@julioramosest
Copy link

julioramosest commented Jun 9, 2023

Find UI design and UX notes here: https://www.figma.com/file/HOx9fsNedtkR2G0bCpHDX9/Resource-actions%2C-previewing-and-more?type=design&node-id=1052%3A9282&t=GRwoA81GZhm0O54t-1

additional note: panes width stickiness is important. When displaying back, user should find their panes as they had previously set up.

also related to #4034

@julioramosest julioramosest added the ux-ready The functionality is ready to be implemented label Jun 9, 2023
@ayushgml
Copy link
Contributor

ayushgml commented Jun 9, 2023

Great design @julioramosest ! I will start working on it. Really excited!

@ayushgml
Copy link
Contributor

Heyy @julioramosest ! I have a doubt. In the following line:
"user should find their panes as they had previously set up." So this happens when the user resizes or when the user exits/enters full screen mode?

@julioramosest
Copy link

hey @ayushgml what I mean by that is that the system needs to have some "memory", in the sense that, when quitting full screen (aka left and middle panes folded), those left and middle panes go back to previous corresponding sizes the user had just prior to going full screen.

@ayushgml
Copy link
Contributor

ayushgml commented Jun 26, 2023

Understood! Thank you @julioramosest!

@ayushgml
Copy link
Contributor

@devcatalin @olensmar The following video is the look till now:

Screen.Recording.2023-06-26.at.7.18.31.PM.mov

I am able to set the maximum height( View height - Header of app - Header of Dashboard) of the Drawer which is child of TableView by including a margin-top: -65px in Tableview. Tableview has 2 children - Table and Drawer. So basically by shifting tableView up by 65px. I shifted both the Table and Drawer up by 65px. But due to the search bar hiding, I added a margin-top:65px to Table. Outcome of this the final position of table is unchanged and the Drawer is shifted up(which we want).
Now I am working on styling the CSS to get exactly the desired look. I'm running into some issues but I will fix it.I will keep you guys updated
@julioramosest I have included the "memory" that you previously mentioned.

@julioramosest
Copy link

@devcatalin not sure if this is out scope for this, but can we have the left pane scroll hidden unless focusing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ux-ready The functionality is ready to be implemented
Projects
Status: No Status
Development

No branches or pull requests

4 participants