Move selector immutability check to validation after v1beta1 retires

[crimsonfaith91]

The check for selector immutability is located at PrepareForUpdate functions of deploymentStrategy, rsStrategy and daemonSetStrategy. We are not able to have the check at validation before v1beta1 API version retires due to breaking change to some tests (discussed in this closed PR). Once v1beta1 retires, we should move the check to validation.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

[liggitt]

the beta types have not been served since 1.16, so this can be done now.

relevant spots to update are in https://grep.app/search?q=TODO%28%2350791%29&filter[repo][0]=kubernetes/kubernetes

[yardenshoham]

/assign

[yardenshoham]

/unassign

[XDRAGON2002]

@crimsonfaith91 is this issue still up for grabs? If so then as a new contributor I would like to take this up.

[yardenshoham]

I had a PR to resolve it but it never got reviewed. If you do grab it:

1. Move selector immutability checks into validation #107858 is a good starting point
2. Expect for it to go unreviewed for a long time

[XDRAGON2002]

I had a PR to resolve it but it never got reviewed. If you do grab it:

1. Move selector immutability checks into validation #107858 is a good starting point
2. Expect for it to go unreviewed for a long time

Thanks a lot @yardenshoham! I did go through your PR and understand the basics of what the issue entails. Also I still can't believe that your PR went unreviewed for an entire year!

[XDRAGON2002]

/assign

[46kumarshivam]

/assign

[kushalShukla-web]

is this issue still open ?

[lavishpal]

/assign