go vet lostcancel errors in legacy-cloud-providers files

[sanposhiho]

What happened?

We found go vet issues of lostcancel in #109184. (It seems that go vet checks are not running under /staging dir.)

staging/src/k8s.io/legacy-cloud-providers/vsphere/nodemanager.go:190:5: lostcancel: the cancel function is not used on all paths (possible context leak) (govet)
				ctx, cancel := context.WithCancel(context.Background())
				^
staging/src/k8s.io/legacy-cloud-providers/vsphere/nodemanager.go:236:3: lostcancel: this return statement may be reached without using the cancel var defined on line 190 (govet)
		}()

We should fix them to ensure we don't introduce context leak as the message said.

What did you expect to happen?

These issues from go vet are fixed.

How can we reproduce it (as minimally and precisely as possible)?

Running go vet under staging/src/k8s.io/legacy-cloud-providers/

Anything else we need to know?

No response

Kubernetes version

latest master

Cloud provider

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

[sanposhiho]

/sig cloud-provider

[sanposhiho]

@liggitt so is this should be resolved before v1.24?

[liggitt]

This has existed for 4 years, so it's not release blocking

[nckturner]

/triage accepted

This is technically a bug, but since its been around for 4 years its not super high priority.

[lubronzhan]

#109184 (comment)
Will try fix the cloud-provider-vsphere part before 1.25

[lubronzhan]

/assign

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[vaibhav2107]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[dims]

looks like this is still an issue

[davanum@c889f3bd53ed 16:02] ~/go/src/k8s.io/kubernetes/staging/src/k8s.io/legacy-cloud-providers ⟩ go vet ./...
go: downloading golang.org/x/crypto v0.1.0
go: downloading golang.org/x/text v0.4.0
go: downloading golang.org/x/net v0.1.1-0.20221027164007-c63010009c80
go: downloading golang.org/x/sys v0.1.0
go: downloading k8s.io/kube-openapi v0.0.0-20221012153701-172d655c2280
go: downloading golang.org/x/term v0.1.0
# k8s.io/legacy-cloud-providers/aws
aws/aws_assumerole_provider_test.go:95:9: range var tt copies lock: struct{name string; fields k8s.io/legacy-cloud-providers/aws.fields; want github.com/aws/aws-sdk-go/aws/credentials.Value; wantProviderCalled bool; sleepBeforeCallingProvider time.Duration; wantErr bool; wantErrString string} contains k8s.io/legacy-cloud-providers/aws.fields contains sync.RWMutex
# k8s.io/legacy-cloud-providers/vsphere
vsphere/nodemanager.go:190:5: the cancel function is not used on all paths (possible context leak)
vsphere/nodemanager.go:236:3: this return statement may be reached without using the cancel var defined on line 190

[Akshit42-hue]

/assign

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[vaibhav2107]

/remove-lifecycle stale

[DeeptanshuDas]

want to contribute but can't get any idea about this issue can anyone give me a short overview of this issue?

[rmiki]

Hello, I'm new to k8s community and finding some good-first-issue to tackle.
I think this issue can be closed because the file have been removed at PR #122937 and is maintained at [1].

[1] https://github.com/kubernetes/cloud-provider-vsphere