Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify cygwin handling in Git Bash #3804

Open
Konfekt opened this issue May 18, 2024 · 0 comments
Open

simplify cygwin handling in Git Bash #3804

Konfekt opened this issue May 18, 2024 · 0 comments

Comments

@Konfekt
Copy link
Sponsor Contributor

Konfekt commented May 18, 2024

Just wondering, if the somewhat involved code in

elseif has('win32unix') && $TERM !=# 'cygwin'

to handle fzf in Cygwin or rather Git Bash nowadays can be simplified, for example by Git Bash including /usr/bin/start calling cmd //c.
This was mainly added in the somewhat lengthy PR #933 so maybe @janlazo has clearer ideas why all these measures have to be taken.
In any event, I am happy that Fzf is working Git Bash at all, that's quite a feat;
just wondering if developer's pain could be eased dealing with all the conversion issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant