Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Servlet spec 6.1 issue 164 #11813

Open
janbartel opened this issue May 20, 2024 · 0 comments
Open

Servlet spec 6.1 issue 164 #11813

janbartel opened this issue May 20, 2024 · 0 comments
Labels
Specification For all industry Specifications (IETF / Servlet / etc)

Comments

@janbartel
Copy link
Contributor

Issue 164 [https://github.com/jakartaee/servlet/issues/164]
Clarify Javadoc for ServletResponse and HttpServletResponse methods that are NO-OPs once the response has been committed.

Affects:

ServletResponse:

  • setContentLength()
  • setContentLengthLong()

HttpServletResponse:

  • addCookie()
  • add/setDateHeader()
  • add/setHeader()
  • add/setIntHeader()
  • setStatus()

See: jakartaee/servlet@96a0267
@janbartel janbartel added the Specification For all industry Specifications (IETF / Servlet / etc) label May 20, 2024
janbartel added a commit that referenced this issue May 21, 2024
@janbartel
Issue #11813 add tests for no-ops on Response after commit.
7fe5b47
@janbartel janbartel mentioned this issue May 21, 2024
Merged
janbartel added a commit that referenced this issue May 28, 2024
@janbartel
Issue #11813 add tests for no-ops on Response after commit. (#11824)
c50d325 
* Issue #11813 add tests for no-ops on Response after commit.

* Change after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Specification For all industry Specifications (IETF / Servlet / etc)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@janbartel