You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should move the integration tests for the jetty maven plugin out of each of the jetty-eeX-maven-plugin subprojects, and move it into submodules of tests instead. This will solve a nasty circular dependency, where the plugin integration tests depend on jetty-home (which in turn depends on each of the eeX subprojects).
The text was updated successfully, but these errors were encountered:
My comment is a nasty circular dependency this is not nasty nor circular but a real dependency :)
To be honest, I think it's a lot of work for minor/none improvement. I would not even see this as a improvement as it will move some test files in another place of the source tree of the maven plugins code and by the way every maven plugins test will still have dependency on jetty-home.
And with the cache, the build is really fast now when testing this locally or via PR.
So, personally, I would not change that.
@olamy there is a circularity via the various eex-home modules: jetty-eex-maven-plugin -> jetty-home -> jetty-eex-home -> jetty-eex-maven-plugin.
My other thought is that we have the tests/test-integration module where we do all kinds of integration tests, so why not the plugin too?
If you want to do it for consistency, just do it. I just find it extra work for no gain but those new modules will still need dependency on jetty-home and so when we will want to test any change with maven plugins the build (up to jetty-home will be the same)
jetty-12
We should move the integration tests for the jetty maven plugin out of each of the
jetty-eeX-maven-plugin
subprojects, and move it into submodules oftests
instead. This will solve a nasty circular dependency, where the plugin integration tests depend onjetty-home
(which in turn depends on each of theeeX
subprojects).The text was updated successfully, but these errors were encountered: