-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why there is no Regex Support for excludeList of nonProxyHost #8329
Comments
What version of Jetty? |
Any version till date.. there is no support for the pattern match there on the line I just tagged to the ticket ! |
@kasingal we accept pull requests. Do you want to try to fix this issue and submit a pull request? Thanks! |
If you decide to do a pull request, make it against branch |
This issue has been automatically marked as stale because it has been a |
I would like to work on this issue. |
Yes, please target branch |
Signed-off-by: Lukas Gisi <lukasgisi@gmail.com>
Signed-off-by: Lukas Gisi <lukasgisi@gmail.com>
Hi - I opened PR #10538. First contribution to this project - feedback is always welcome.
I think this satisfies most use cases. If we (you) also want to support wildcards in the middle maybe something like this works better: String hostRegex = Arrays.stream(host.split("\\*"))
.map(s -> {
if (s.length() > 0) {
return Pattern.quote(s);
}
return s;
})
.collect(Collectors.joining(".*")); |
…r same hosts Signed-off-by: Lukas Gisi <lukasgisi@gmail.com>
… patterns Signed-off-by: Lukas Gisi <lukasgisi@gmail.com>
Code at line below should be enhanced:
https://github.com/eclipse/jetty.project/blob/8102378e2d24b8117ed3a545c7579f79d35fc45a/jetty-client/src/main/java/org/eclipse/jetty/client/ProxyConfiguration.java#L180
Generally nonProxyHosts gets defined with wildcards like
*.abc.com|*.svc.local
etc.. so.equals
doesn't help !And apparently Jetty Client doesn't have any support for wildcard list of nonProxyHosts !!
PS: reactor-netty handles it pretty well, refer below:
https://github.com/reactor/reactor-netty/blob/main/reactor-netty-core/src/main/java/reactor/netty/transport/ProxyProvider.java#L310
The text was updated successfully, but these errors were encountered: