Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Multiple ingress with same secret Fixes #298 #320

Closed
wants to merge 2 commits into from
Closed

Multiple ingress with same secret Fixes #298 #320

wants to merge 2 commits into from

Conversation

ebati
Copy link

@ebati ebati commented Mar 2, 2018

Fixes #298

  • Created constructor function for ingress.Tls which extracts required info from k8s.tls.
  • Added ability to add host to Tls.
  • Changed TlsIgnoreDuplicatedSecrets to accept secret referenced from multiple ingress. But merge hosts from those ingresses.

@jetstack-bot
Copy link
Collaborator

Hi @ebati. Thanks for your PR.

I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ebati ebati closed this Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ok-to-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Certificates referenced by multiple ingress should be renewed
2 participants
@ebati @jetstack-bot