Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argon 2.3.1 on OpenWrt 23.05.3 - Browser Website Appearance Settings Override Argon Theme Mode Configuration (Light Mode / Dark Mode) #500

Open
boktai1000 opened this issue May 18, 2024 · 3 comments

Comments

@boktai1000
Copy link

Describe the bug
When configuring Light Mode in Argon config, when using Firefox browser the web interface will stay in dark mode. Using another browser such as Chrome will properly show Light Mode.

To Reproduce
Steps to reproduce the behavior:

  1. Use Mozilla Firefox
  2. Configure Theme mode to Light Mode
  3. Observe that the background does not change, and confirm against another browser.

Expected behavior
Light Mode would be present

Screenshots
If applicable, add screenshots to help explain your problem.
Example here:
image

Openwrt (please complete the following information):

  • Versiosn: 23.05.3
  • Theme: Argon (manually installed via Snapshot, and fantastic-builds repository)
  • Version: 2.3.1

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Firefox
  • Version: Windows 10, Firefox Latest (126)

Additional context
Add any other context about the problem here.

@qingtian110
Copy link

it works!

image
image

@boktai1000
Copy link
Author

boktai1000 commented May 19, 2024

I have some more data to report.

The issue also occurs for me on Microsoft Edge on Windows 10 x64
The issue does not occur for me with Google Chrome on Windows 10 x64
The issue does not occur for me on Microsoft Edge through a fresh Hyper-V VM for Windows 11

I have tried disabling all extensions (ublock origin and bitwarden) and loading the page as well as a full cache clean to no avail.

My primary computer that I'm reporting the issue through is Windows 10 x64 - latest updates - and my color settings are as follows (although I've obviously tried setting Light Mode, but tried messing with app/window mode default to see if that might trigger something - nada)

image

Thank you for posting a working image, clearly there is something more going on than meets the eye

@boktai1000 boktai1000 changed the title Argon 2.3.1 on OpenWrt 23.05.3 - Light Theme does not work on Firefox Browser Argon 2.3.1 on OpenWrt 23.05.3 - Light Theme not working properly in some circumstances for some browsers (Firefox, Edge) but not Chrome May 19, 2024
@boktai1000
Copy link
Author

boktai1000 commented May 19, 2024

Update - I did some Googling and came across this:

Firefox - Website appearance set to Dark - about:preferences#searchResults

image

Edge - https://www.reddit.com/r/MicrosoftEdge/comments/1ayyiu6/stuck_in_dark_mode_how_do_i_turn_it_off/ - edge://settings/?search=dark

image

I can confirm that setting either of these options to System Default/Automatic will "fix" this or work as expected, but hear me out as I still believe there is an issue here.

I think this is still a bug though, because I would expect Argon/LuCI to be able to override this through the configuration, and it doesn't seem possible. I've never really encountered a situation like this before, but I'm happy I found out what's causing it now.

@boktai1000 boktai1000 changed the title Argon 2.3.1 on OpenWrt 23.05.3 - Light Theme not working properly in some circumstances for some browsers (Firefox, Edge) but not Chrome Argon 2.3.1 on OpenWrt 23.05.3 - Browser Website Appearance Settings Override Argon Theme Mode Configuration (Light Mode / Dark Mode) May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants