Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more platform-specific cni bindir/confdir autodetect in istio-cni Helm chart #51121

Open
bleggett opened this issue May 17, 2024 · 1 comment
Labels

Comments

@bleggett
Copy link
Contributor

bleggett commented May 17, 2024

Describe the feature request

Right now we use Helm variables to autodetect and set the correct istio-cni bin dir for GKE:

https://github.com/istio/istio/blob/master/manifests/charts/istio-cni/templates/daemonset.yaml#L4

Right now GKE is the only "production" platform that seems to need this override, but several mini/local clusters require similar overrides: https://istio.io/latest/docs/ambient/install/platform-prerequisites/

We should look into expanding this autodetection for other platforms/kube variants that need similar overrides. We should also look at whether we want to do this with Helm installtime detection, or Helm profiles (sorta like we already do for openshift - do we want templating autodetect, or do we want something like helm install XXX --profile=platform-k3d?)

Should work for:

  • Helm (must-have)
  • Istioctl (must-have)
  • manual template gen + manual apply (not must-have)

Describe alternatives you've considered

Affected product area (please put an X in all that apply)

[x] Ambient
[ ] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Affected features (please put an X in all that apply)

[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane

Additional context

@howardjohn
Copy link
Member

k3s/rancher/similar would be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants