-
-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SonarCloud reports issues #1012
Comments
Can I take this issue? |
Sure @ykayacan |
This issue is free for taking again. |
I would like to take this issue. |
Through out checking the files causing issues on SonarCloud, I've encountered test cases that are not properly named to the functionality that they are to be tested against. Example` In-correct naming convention of a test method.
Correct naming convention of a test method.
A test method should describe what its testing directly in the naming, I will rename the test cases that I find throughout the refactoring process to match proper convention rules, if the test case is understandable as to what it's testing, but I would encourage that these test cases be looked at and properly named for other contributors making changes to certain files that the test cases test against, otherwise it causes a lot of confusion as to whether said contributor is testing the right thing. |
Ok @ToxicDreamz, assigned to you. I agree with your comment regarding test naming. |
I've already finished with the issue. Request to run another SonarCloud report after merging, to see what else remains, and whether or not they can be modified so issues do not come up again. |
13 blockers and 24 criticals remaining: https://sonarcloud.io/project/issues?id=iluwatar_java-design-patterns&resolved=false&severities=BLOCKER%2CCRITICAL |
|
@iluwatar happy to be back again :) |
Ok, go ahead @ShivanshCharak |
Raised a pr for the following Critical code smell please also review |
… several AppTest classes (iluwatar#1784) Co-authored-by: Subhrodip Mohanta <hello@subho.xyz>
Can I help? |
Ok @S7sRuss, thanks for the help |
… upgrade later on
… upgrade (iluwatar#2125) * refactoring iluwatar#1012: Remove deprecated method to ease Hibernate upgrade later on * refactoring iluwatar#1012: Fix checkstyle violation
…ibernate upgrade (iluwatar#2125)" This reverts commit 9822f04.
…f string concatenation.
…f string concatenation.
…f string concatenation.
…f string concatenation.
The project is using SonarCloud static code analysis. The latest results are showing that it has found several blockers and critical severity code smells (major, minor, and info level we ignore). In this task, those are fixed or marked as false positives. To mark false positives, SuppressWarnings annotation should be used in code as explained in the linked documentation.
Links:
Blocker and critical severity code smells in SonarCloud
Sonar false positives
Note: When Submitting a PR please provide a hyperlinked list of all the issues that you are issuing a fix for. See this example
The text was updated successfully, but these errors were encountered: