-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL language causes misalignment of slider labels #4904
Comments
2 tasks
2 tasks
low-batt
added a commit
that referenced
this issue
May 8, 2024
This commit will: - Add outlets for speed slider labels and other components to the QuickSettingViewController class - Add outlets for constraints controlling the position of speed slider labels to the QuickSettingViewController class - Add methods awakeFromNib, calculateSliderLabelMultiplier and viewWillLayout to the QuickSettingViewController class to replace constraints when in a right to left layout - Add a convertSpeedToSliderValue method to the QuickSettingViewController class to eliminate duplication of a formula These changes cause IINA to replace the layout constraints that control the position of the labels under the speed slider in the video panel that identify the speed associated with particular slider tick marks with constraints that properly position the slider labels when the user interface layout direction is right to left.
2 tasks
2 tasks
uiryuu
pushed a commit
that referenced
this issue
May 24, 2024
This commit will: - Add outlets for speed slider labels and other components to the QuickSettingViewController class - Add outlets for constraints controlling the position of speed slider labels to the QuickSettingViewController class - Add methods awakeFromNib, calculateSliderLabelMultiplier and viewWillLayout to the QuickSettingViewController class to replace constraints when in a right to left layout - Add a convertSpeedToSliderValue method to the QuickSettingViewController class to eliminate duplication of a formula These changes cause IINA to replace the layout constraints that control the position of the labels under the speed slider in the video panel that identify the speed associated with particular slider tick marks with constraints that properly position the slider labels when the user interface layout direction is right to left.
1 task
uiryuu
pushed a commit
that referenced
this issue
May 25, 2024
This commit will: - Add outlets for speed slider labels and other components to the QuickSettingViewController class - Add outlets for constraints controlling the position of speed slider labels to the QuickSettingViewController class - Add methods awakeFromNib, calculateSliderLabelMultiplier and viewWillLayout to the QuickSettingViewController class to replace constraints when in a right to left layout - Add a convertSpeedToSliderValue method to the QuickSettingViewController class to eliminate duplication of a formula These changes cause IINA to replace the layout constraints that control the position of the labels under the speed slider in the video panel that identify the speed associated with particular slider tick marks with constraints that properly position the slider labels when the user interface layout direction is right to left.
Should close as resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
System and IINA version:
Expected behavior:
The text fields under the slider for the
Speed
setting on theVIDEO
tab of the quick settings panel are properly aligned with the tick marks they are intended to label.Actual behavior:
Currently IINA does not support any right to left languages. However PR #4922 enables Hebrew. If you build IINA with that pull request and set Hebrew as the language then show the video panel the labels under the slider for the
Speed
settings are misaligned:The labels should look like this:
I believe this problem is responsible for these constraint errors:
Errors displayed in Xcode console::
Steps to reproduce:
Pull PR feat: enable hebrew locale #4922
Open the IINA project in Xcode
Under the
Product
menu open theScheme
menu and selectEdit Scheme…
Click on the
Options
tabScroll down to the
App Language
settingIn the pull down select
Hebrew
Start IINA running under Xcode
Start playing a video
Press ⇧⌘V to show the video panel
Notice the labels under the slider for
Speed
are misaligned or missingMPV does not have this problem.
mpv does not support localization.
How often does this happen?
Every time.
The text was updated successfully, but these errors were encountered: