Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointer to Segment in SegmentAccessor might expire #2379

Open
mrks opened this issue Jun 28, 2021 · 0 comments
Open

Pointer to Segment in SegmentAccessor might expire #2379

mrks opened this issue Jun 28, 2021 · 0 comments

Comments

@mrks
Copy link
Member

mrks commented Jun 28, 2021

SegmentAccessor::_segment is just a reference. In some cases, we seem to create accessors and let the shared_ptr to the segment expire. This can lead to the segment being deleted while the accessor is still existant.

Either fix those cases and make sure that the shared_ptr is held for long enough (might be difficult with ReferenceSegments) or simply make _segment a shared_ptr (and check the performance impact).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant