Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill PerformanceWarning #2348

Open
mrks opened this issue Apr 7, 2021 · 1 comment
Open

Kill PerformanceWarning #2348

mrks opened this issue Apr 7, 2021 · 1 comment
Assignees
Labels

Comments

@mrks
Copy link
Member

mrks commented Apr 7, 2021

As discussed in the fortnightly, the PerformanceWarnings have no clear semantics. Who is warned about what? Right now, they look like glorified TODO comments. Remove them and replace them with either TODO comments or explicit prints (especially in the TPC-C binary).

@tjjordan tjjordan self-assigned this Mar 23, 2022
@tjjordan
Copy link
Member

tjjordan commented Apr 7, 2022

As discussed in the fornightly, a good solution is not yet found.

The use of print-statements worsens the spam to the console, which in general opinion should be prohibited.
It could be an option for extremely performance-critical codepaths, but I think it could be better to make them inaccessible.

Other discussed options were the use of a logging infrastructure or mentioning the warnings in comments or in a separate file, but this is very easy to ignore.

For further discussion a separate meeting is planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants