Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role Mapper - sensitive data in oidc-config #8777

Closed
arnmohan opened this issue May 17, 2024 · 2 comments
Closed

Role Mapper - sensitive data in oidc-config #8777

arnmohan opened this issue May 17, 2024 · 2 comments
Assignees
Labels
question Further information is requested
Projects

Comments

@arnmohan
Copy link

Environment Details

  • Helidon Version: 3.2.8
  • Helidon SE or Helidon MP: Helidon MP
  • JDK version: JDK 17

Problem Description

Role Mapper is currently using IDCS client secret from oidc-config which is sensitive data .

oidc-config:
client-id: "client-id"
client-secret: " ***** "
identity-uri: "IDCS identity server address"

We need to ensure sensitive data in OIDC config could potentially come from Vault (i.e., if oidc-config is an OCID to vault-secret then resolve it from OCI)

@github-actions github-actions bot added this to Triage in Backlog May 17, 2024
@m0mus m0mus added the question Further information is requested label May 23, 2024
@arjav-desai
Copy link
Member

arjav-desai commented May 23, 2024

You can encrypt config values, please see section "encryption" under https://helidon.io/docs/latest/mp/config/introduction and https://helidon.io/docs/latest/mp/security/configuration-secrets

@m0mus m0mus closed this as completed May 30, 2024
Backlog automation moved this from Triage to Closed May 30, 2024
@arnmohan
Copy link
Author

arnmohan commented Jun 7, 2024

security.config:

require-encryption: false
aes.insecure-passphrase: "myMasterPasswordForEncryption"
rsa:
keystore:
# load from classpath
resource.resource-path: ".ssh/keystore.p12"
# If keystore is used, alias to use from the keystore (in this example, it is "1")
key.alias: "1"
# Password of keystore
passphrase: "helidon"

In this example, do we need a file to keep the encryption key ? if so where do we store file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Backlog
  
Closed
Development

No branches or pull requests

3 participants