This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
Add Docker Healthcheck to both containers. #893
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it might be better to hit the status endpoint, rather than just the root URL? At |
|
Didn't know about this endpoint. Hope it returns anything else than |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR introduced Docker Healthcheck to normal and rootless containers. It is Based on GoogleContainerTools/distroless#183 (comment)
Which issue(s) this PR fixes:
Fixes #890
Special notes for your reviewer:
You asked for PR 😄
Testing
Container was build and after 30 Seconds marked as
healthy. Also GET request to the/can be seen in the logs.Release Notes