src/ssl_ckch.c: null pointer dereference suspected by coverity

[chipitsine]

Tool Name and Version

coverity

Code Report

** CID 1545821:    (REVERSE_INULL)
/src/ssl_ckch.c: 4220 in ckch_conf_cmp()
/src/ssl_ckch.c: 4200 in ckch_conf_cmp()


________________________________________________________________________________________________________
*** CID 1545821:    (REVERSE_INULL)
/src/ssl_ckch.c: 4220 in ckch_conf_cmp()
4214                    /* special case for ocsp-update and default */
4215                    if (strcmp(ckch_conf_kws[i].name, "ocsp-update") == 0) {
4216                            int o1, o2; /* ocsp-update from the configuration */
4217                            int q1, q2; /* final ocsp-update value (from default) */
4218     
4219     
>>>     CID 1545821:    (REVERSE_INULL)
>>>     Null-checking "prev" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
4220                            o1 = prev ? *(int *)((intptr_t)prev + (ptrdiff_t)ckch_conf_kws[i].offset) : 0;
4221                            o2 = new ? *(int *)((intptr_t)new + (ptrdiff_t)ckch_conf_kws[i].offset) : 0;
4222     
4223                            q1 = (o1 == SSL_SOCK_OCSP_UPDATE_DFLT) ? global_ssl.ocsp_update.mode : o1;
4224                            q2 = (o2 == SSL_SOCK_OCSP_UPDATE_DFLT) ? global_ssl.ocsp_update.mode : o2;
4225     
/src/ssl_ckch.c: 4200 in ckch_conf_cmp()
4194                    if (strcmp(ckch_conf_kws[i].name, "crt") == 0)
4195                            continue;
4196     
4197                    switch (ckch_conf_kws[i].type) {
4198                            case PARSE_TYPE_STR: {
4199                                    char *avail1, *avail2;
>>>     CID 1545821:    (REVERSE_INULL)
>>>     Null-checking "prev" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
4200                                    avail1 = prev ? *(char **)((intptr_t)prev + (ptrdiff_t)ckch_conf_kws[i].offset) : NULL;
4201                                    avail2 = new ? *(char **)((intptr_t)new + (ptrdiff_t)ckch_conf_kws[i].offset) : NULL;
4202     
4203                                    /* must alert when strcmp is wrong, or when one of the field is NULL */
4204                                    if (((avail1 && avail2) && strcmp(avail1, avail2) != 0) || (!!avail1 ^ !!avail2)) {
4205                                            memprintf(err, "%s- different parameter '%s' : previously '%s' vs '%s'\n", *err ? *err : "", ckch_conf_kws[i].name, avail1, avail2);

Additional Information

No response

Output of haproxy -vv

no

[wlallemand]

Thanks, fixed.