Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore: Show the edit form to define query template properties (when adding from query history) #88043

Closed
Tracked by #83096
ifrost opened this issue May 20, 2024 · 6 comments · Fixed by #88211
Closed
Tracked by #83096
Assignees
Labels
area/query-library Query Library / High & Peak Q / Explore's Shared Queries

Comments

@ifrost
Copy link
Contributor

ifrost commented May 20, 2024

Show a drawer to fill-in properties for a query template.

@ifrost ifrost added the area/query-library Query Library / High & Peak Q / Explore's Shared Queries label May 20, 2024
@ifrost ifrost self-assigned this May 20, 2024
@ifrost ifrost changed the title Explore: Show a drawer to define query template properties Explore: Show the edit form to define query template properties (when adding from query history) May 20, 2024
@ifrost
Copy link
Contributor Author

ifrost commented May 22, 2024

Looks slightly different than on designs when using default components from grafana-ui:

Design grafana-ui
Screenshot 2024-05-22 at 15 12 26 Screenshot 2024-05-22 at 15 47 25

@diegoadams should we go with grafana-ui (should be more consistent with the rest of IU) or tweak it as per deisgns?

@diegoadams
Copy link

Hey @ifrost , is there anyway I could see an Ephemeral of it? if not please could you do a video. I just want to see it in full context.

@ifrost
Copy link
Contributor Author

ifrost commented May 23, 2024

Hey @ifrost , is there anyway I could see an Ephemeral of it? if not please could you do a video. I just want to see it in full context.

Sure-io! I'll create one 👍

UPDATE: @diegoadams it's here https://ephemeral1511182188211ifrost.grafana-dev.net/

@diegoadams
Copy link

thanks @ifrost , The Grafana UI version looks good! The only suggestion I have is to change the auto-star toggle look.

If possible, could we take it out of the current field and leave it as per the design.

Screenshot 2024-05-23 at 22 34 51

@ifrost
Copy link
Contributor Author

ifrost commented May 23, 2024

If possible, could we take it out of the current field and leave it as per the design.

Sure! It's gonna be non-standard and inconsistent compared to other parts of Grafana, though - the switch is always on right side of the label. Is it okay UX-wise to mix placement of the toggle? If yes - we can make adjustments to the shared component so it can happen in other places too.

Some examples of the toggle:

Screenshot 2024-05-23 at 10 20 34 Screenshot 2024-05-23 at 10 20 12 Screenshot 2024-05-23 at 10 19 23

@diegoadams
Copy link

If yes - we can make adjustments to the shared component so it can happen in other places too.

Ok, leave it as is for now (as grafana UI default) and I will bring it up with UX team in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/query-library Query Library / High & Peak Q / Explore's Shared Queries
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants