-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Sending deprecated Content-Type header #93
Comments
"application/xml" seems to work fine. Not sure how well "application/rss+xml" is supported, I checked in chrome and it is not being formatted properly when served as "application/rss+xml".
|
"Seems to work fine" is not a good reason to violate an official standard. Also, define "work". RSS feeds are designed to be read by RSS readers. They are not meant to be consumed by end users as nicely formatted XML (even though that can sometimes be useful for developing). Earlier most browsers had built-in RSS readers, but these days practically all of them have removed that functionality in favour of browser plugins or separate programs. Now, the only way to tell the browser to open the feed in said piece of software is to use a dedicated content-type, otherwise the output will be hijacked by the browser and shown as XML (or handed to a dedicated XML formatter plugin). So it all depends on who your target audience are. Do you want to format XML for the benefit of developers, use |
The extensions shared above do properly handle content type How are how you serving the feed? You should be able to set the desired |
Describe the bug
Currenly Gorilla outputs the Content-Type header as "application/xml". According to the RSS Standard Board, the correct Content-Type should be "application/rss+xml".
Versions
go version go1.17.5 linux/amd64
github.com/gorilla/feeds v1.1.1
Steps to Reproduce
Expected behavior
The text was updated successfully, but these errors were encountered: