Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Wrong Condition for Checking the File Identifier [.NET/C#, master] #8308

Open
abduelhamit opened this issue May 15, 2024 · 0 comments
Open

Comments

@abduelhamit
Copy link

The comments on Verifier.VerifyBuffer say:

When empty identifier is provided the identifier validation is skipped.

However, the condition for checking the file identifier only triggers if the provided identifier is "", which always leads to the ArgumentException:

FlatBuffers: file identifier must be length4

Changing (identifier.Length == 0) to (identifier.Length != 0) provides the right behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant