Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python < 3.12 #754

Open
TimKnight-DWP opened this issue May 8, 2024 · 3 comments
Open

Drop python < 3.12 #754

TimKnight-DWP opened this issue May 8, 2024 · 3 comments
Labels
4.x release Candidate for potential v4 release

Comments

@TimKnight-DWP
Copy link
Collaborator

3.8 EOL 10-2024
3.9 EOL 10-2025

We will need to drop them anyway by the above dates

If we dropped these earlier we could support Obj | Obj typing for example Group | Project which is going to become more and more useful as we adopt python-gitlab.

@TimKnight-DWP
Copy link
Collaborator Author

Obviously this would be a breaking-change, we could consider a cut off point, for example:
Support upto GitLab 17.0 on 3.8 & 3.9, but future major feature development for GL 18+ would only support 3.10.

As have discussed in Slack, if we were to adopt something like release-please we could support a secondary release branch for hot fixes to the previous major version

@amimas
Copy link
Collaborator

amimas commented May 13, 2024

we could support a secondary release branch for hot fixes to the previous major version

Personally I'd avoid multiple version support. It'll bring additional maintenance that I think we don't need or can afford.

@gdubicki gdubicki changed the title Drop python 3.8 and 3.9 Drop python < 3.12 May 15, 2024
@gdubicki gdubicki added the 4.x release Candidate for potential v4 release label May 16, 2024
@gdubicki
Copy link
Member

I wanted to share with others who might be reading this issue that we discussed this within the maintainers team and agreed to stop supporting all version of Python except the latest stable.

The benefits would be:

  • enabling new syntax for optimal development experience,
  • less tests to run - less chance of running into flakiness, lower CI/CD use which could help if we move to GitLab and GitLab CI, lower resource use is better for the environment 🌱
  • optimal performance as new Python versions are faster (but it's not a very significant factor in our case),

The downsides:

  • some users will have to switch to run the app with Docker if they are stuck with old Python but a) the switch is easy, b) they will have to switch or upgrade Python at some point anyway,
  • we may alienate some potential contributors who are stuck with old Python on their dev envs? - not sure if that’s really a realistic scenario, is anyone really using something like Centos 7 or Ubunto 18.04 on a desktop?

If anyone has anything to add here, in particular something that would make us change our minds, please share your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x release Candidate for potential v4 release
Projects
None yet
Development

No branches or pull requests

3 participants