Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'enforce' support for integrations config #741

Open
amimas opened this issue Apr 29, 2024 · 3 comments
Open

Add 'enforce' support for integrations config #741

amimas opened this issue Apr 29, 2024 · 3 comments
Labels
✨feature request good first issue Good issue for first-time contributors help wanted

Comments

@amimas
Copy link
Collaborator

amimas commented Apr 29, 2024

Several config sections of gitlabform supports the usage of enforce: true. This allows automatically deleting the resources under that section that is not present in gitlabform config. This feature request is to add same support to the integrations config.

@amimas amimas added ✨feature request good first issue Good issue for first-time contributors help wanted labels Apr 29, 2024
@adam-moss
Copy link

This may be slightly more tricky than it first appears. E.g. where an integration needs to authenticate on first use. I'm sure we hit this ourselves with testing @TimKnight-DWP ?

@TimKnight-DWP
Copy link
Collaborator

Honestly I don't recall, but I can definetly see the problem where an OAuth loop gets triggered within GLF run

@amimas
Copy link
Collaborator Author

amimas commented May 31, 2024

I have used only a couple integrations, I think. The enforce feature will only try to delete an integration. Is there any authentication involved at this stage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨feature request good first issue Good issue for first-time contributors help wanted
Projects
None yet
Development

No branches or pull requests

3 participants