Merge request approvals settings of group

[rogierlommers]

Hey! First of all, I like your project. We're playing a bit with our gitlab configurations and how to apply it within the organization. The documentation is quite clear for us, but there is one thing I don't really understand. Basically the question is: how do I change the settings in the screenshot below (so on group level).

We want to set the request-approval-rules on a group basis. This setting should be inherited to all the groups/projects that will be created inside this group. is this possible?

With the code snippet below i can "walk through" all repositories and change the settings after creation. However, I want to avoid that new projects/repos have the setting prevent approval by author to value false.

---
config_version: 3
gitlab:

projects_and_groups:
  '*':
    merge_requests_approvals:
      reset_approvals_on_push: false
      merge_requests_author_approval: true
      disable_overriding_approvers_per_merge_request: true

[rogierlommers]

A bit more information: it turns out that the gitlab API does support these operations:

[EDIT]

curl --header "PRIVATE-TOKEN: xxx" --header "Content-Type: application/json" -X PUT  --data  <<SEE BELOW>>'' https://gitlab/api/v4/groups/25459/merge_request_approval_setting

REQUEST BODY

{
   "require_password_to_approve":false,
   "allow_author_approval":false,
   "allow_overrides_to_approver_list_per_merge_request":false,
   "require_password_to_approve":false,
   "retain_approvals_on_push":false,
   "selective_code_owner_removals":false,
   "allow_committer_approval":false
}

[amimas]

Hi 👋 . Based on your latest comment, I think you want to manage "merge request approval" setting in a group. Please confirm. If that's the case, I believe this is not supported by gitlabform at the moment. You'll find the gitlabform docs on this setting specifying that the available config is for a project level setting.

With the code snippet below i can "walk through" all repositories and change the settings after creation. However, I want to avoid that new projects/repos have the setting prevent approval by author to value false.

To me, the above is a bit confusing. Even if you configure the setting in a group manually (without gitlabform), it will be inherited by all projects under that group. I'm not aware of any option to control the setting to not be applied on newly created projects after this setting is configured.

Anyways, PR is welcome for adding support for group level configuration of merge request approval setting. Will you be able to contribute this feature?

[amimas]

A bit more information: it turns out that the gitlab API does support these operations:

[EDIT]

curl --header "PRIVATE-TOKEN: xxx" --header "Content-Type: application/json" -X PUT  --data  <<SEE BELOW>>'' https://gitlab/api/v4/groups/25459/merge_request_approval_setting

Could you please point to the API doc? I was looking at following doc page and it didn't show the API endpoint from your example, although it showed up from their search. Also, some of the data in your example doesn't seem to exist on this page. Wondering if I'm looking at the wrong page or they have an issue with their documentation.

https://docs.gitlab.com/ee/api/merge_request_approvals.html

[rogierlommers]

Will do later-on, a bit time constraint now. Will follow-up asap. Thanks, @amimas !