Add support for member_role_id

[adam-moss]

A clear and concise description of what you want to happen.

Add support for member_role_id in https://github.com/gitlabform/gitlabform/blob/main/gitlabform/gitlab/members.py

This will allow for the configuration of custom roles

Thanks.

[amimas]

Hey @adam-moss - Shouldn't this be supported already since the member_role_id is just another attribute of group/project members API.

I didn't check the code yet. Since gitlabform follows the raw parameter passing pattern, in theory it should already be supported. I'm not able to validate it. Would you be able to try?

[amimas]

@adam-moss - did you get a chance to try it out yet?

[adam-moss]

Hey apologies on the delay in replying. No, it doesn't work as the data variable is hand tooled for those routines not passed directly. We'll contribute the change 👍

[amimas]

Thank you for verifying. I just took a quick peak at the code for project membership. Looks like "all the data" from the config is not being passed to the API like I had assumed. What's being passed to the API right now is access_level and expires_at...

gitlabform/gitlabform/processors/project/members_processor.py

Lines 142 to 152 in f7c5922

	self.gitlab.edit_member_of_project(
	project_and_group, common_username, access_level, expires_at
	)
	else:
	debug(
	"Adding user '%s' who previously was not a member.",
	common_username,
	)
	self.gitlab.add_member_to_project(
	project_and_group, common_username, access_level, expires_at
	)

Looking forward to the update. I guess this will only take care of adding an existing "custom role" as member. Maybe we should open a separate feature request to have gitlabform to manage the custom roles?

[adam-moss]

Custom roles is, currently, graphql only. Do we have a vision for how that would be integrated?

[amimas]

In my opinion, it makes sense that this is available via python-gitlab library. There's an open issue about it too

python-gitlab/python-gitlab#1357

Of course I can't speak for that library. Hopefully maintainers of the library also agree. Even then not sure if they have the capacity to provide that option.

Don't know if there's another equivalent library. The really last option I think would be to just implement it in gitlabform but my suggestion would be to create a separate project that basically builds the library and then consume it here.

[TimKnight-DWP]

@amimas @adam-moss - I'll look at adding member_role_id into the relevant places on the REST APIs but if we want/need to support creation, then yeah I think adding initial GraphQL support to python-gitlab would probably be the way to go