-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support job_token_scope
configuration
#607
Comments
Hello. I believe this is same/duplicate of issue #571 . Could you please confirm? |
It's closely related, feel free to combine the two issues if appropriate. But the PATCH request only sets a boolean flag for the project, it doesn't allow fine grained control provided by the allowlist. |
Thanks for clarifying. I think it's fine for this to be a separate issue. Can be implemented without everything related to job token being involved. Keeps the scope small. PRs are welcome. Would you be able to help contribute this feature? Do you have a proposal for the config syntax? |
That sounds great!! Thanks. |
@amimas @hertzsprung changes to support this are here: TimKnight-DWP#1 Currently on my fork only because I need to point at my fork of python-gitlab to pick up that part of the chain. Everything is capable of being merged when gitlab 16.10 gets released, so I'll update the MR to point back to mainline python-gitlab when this MR goers in python-gitlab/python-gitlab#2816. However a review of the proposed changes would be great if possible :) |
GitLab provides a
PATCH
request to enable or disable a project'sjob_token_scope
.But, as far as I'm aware, this is not yet supported by gitlabform.
The text was updated successfully, but these errors were encountered: