Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we remove mypy type checking or validation #586

Open
amimas opened this issue Aug 4, 2023 · 3 comments
Open

Should we remove mypy type checking or validation #586

amimas opened this issue Aug 4, 2023 · 3 comments

Comments

@amimas
Copy link
Collaborator

amimas commented Aug 4, 2023

          Frankly I am fed up with constant mypy issues. I don’t recall any case where it helped while I remember many ones where it was just an nuisance. I propose to get rid of this check completely. Any objections, @amimas ?

Originally posted by @gdubicki in #585 (comment)

@amimas
Copy link
Collaborator Author

amimas commented Aug 4, 2023

I like the concept or idea of type checking and validation. But, I'm really new to Python and don't have enough experience to suggest whether to keep using mypy for this project or not. I'd go with your expertise @gdubicki . Hopefully we hear from other experienced contributors as well.

@adam-moss
Copy link

I use type checking, and mypy, generally without issue, with the type annotation settings turned on in vs-code and a bit of policing from ruff.

I'd be more inclined to use pydantic on anything new though.

@gdubicki
Copy link
Member

Isn’t pydantic use-case a bit different, @adam-moss? I haven’t used it but based on what I read is more of a data validation solution than a type-checker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants