-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(form): add custom string slice for form tag unmarshal (#3970) #3971
Conversation
format the code for better review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3971 +/- ##
==========================================
- Coverage 99.21% 99.05% -0.16%
==========================================
Files 42 44 +2
Lines 3182 2755 -427
==========================================
- Hits 3157 2729 -428
+ Misses 17 15 -2
- Partials 8 11 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
please add test case |
Test cases have been added, please review them again. Thank you. |
Is it possible to add this for arrays as well? A use case for me would be converting a UUID to a binary uuid, which is a |
Yes. There will be some custom arrays for business purposes, such as Mongo's ObjectID, which is a [12]byte. |
Resolves #3970