Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Audio App crashes Portapack #350

Open
helmarw opened this issue Apr 30, 2020 · 32 comments
Open

Audio App crashes Portapack #350

helmarw opened this issue Apr 30, 2020 · 32 comments

Comments

@helmarw
Copy link

helmarw commented Apr 30, 2020

when switching from Audio app to e.g. TPMS and then back to Audio, Portapack crashes
see short video I recorded, happens also from other apps but only when going back to Audio

IMG_5604.mp4.zip

i m using the version just downloaded and compiled 2-3 hours ago.
the version I downloaded and compiled about three weeks ago (04-08 I think) did not have this issue as far as I know

@eried
Copy link

eried commented May 2, 2020

Can you test both versions and be sure that the older one works? If you tell me the timestamp of the one that works vs the one that does not I can check the differences.

BTW I compiled the "latest" -> https://github.com/eried/portapack-havoc/releases

@helmarw
Copy link
Author

helmarw commented May 2, 2020

k, will let you know, luckily i saved the "old" one, alt least the binary.
i will load it up and see if i can reproduce it there

@helmarw
Copy link
Author

helmarw commented May 2, 2020

my mistake, havnt tested the older version very much (downloaded and compiled 8th April 2020). it has the same error.
it only happens when Audio is in WFM-mode, switching to TPMS and than back to Audio. that crashes the whole thing
second when i put audio in SPEC-mode and then change to TPMS i get a red screen (M4 GURU Meditation unhandled)... two short videos about that behaviour
crashes.zip

other modes AM and NFM are not influenced either way. I didnt test any other apps, too many possible combination, it just happend that i was using exactly those two configurations for testing my TPMS sensors

@eried
Copy link

eried commented May 3, 2020

Strange I do not get a lock if I repeat exactly what you do in those videos, it might be a faulty portapack?

PS: btw! I noticed what a beautiful case, the mirrored engraved text worked flawlessly! 🤣🤣🤣

@helmarw
Copy link
Author

helmarw commented May 3, 2020

i dont know what the Problem can be, that just how it is with my portapack

thnx, the housing is great, i printed it on a Formlabs Form2, work very well :)

@fcanaan
Copy link

fcanaan commented May 6, 2020

I can replicate this as well. If i go into the audio app, set it to WFM, exit and then go into ACARS or TPMS i get a had lock with a red screen reading "M4 Guru Medidtation Unhandled". I can also lock up the audio receiver, by going into WFM mode, exiting audio receiver, and then reopening it. The main screen then partially loads the and then hard locks. Seems to be something caused by WFM mode in the audio app. If i can provide anymore information, please let me know.

@eried
Copy link

eried commented May 6, 2020

I do not get the exact same type of lock up, but if I do audio, ACARS/TPMS and then back to audio, the audio app locks the portapack (only the upper part refreshes). Maybe some missing initialization stuff, I will play around it to see if I can find something

@eried
Copy link

eried commented May 6, 2020

Only with the audio app? I could check the initialization of that one but it would be helpful if you both @fcanaan @helmarw test all 👷‍♂️ the possible entering/exiting situations that work weird to pin point what is going on.

@fcanaan
Copy link

fcanaan commented May 6, 2020 via email

@eried
Copy link

eried commented May 6, 2020

Find the same problem in another app/in-out combination. Im no expert on the code, but with a few examples, it will be evident to fix 😂 I hope lol

@fcanaan
Copy link

fcanaan commented May 6, 2020 via email

@fcanaan
Copy link

fcanaan commented May 7, 2020

I’ve found a repeatable M4 Guru error.
Turn unit on
Select Receivers
select pocsag wait 5 seconds then exit
Select audio. change to spec mode. wait 5 seconds then exit
select radiosonde
M4 Guru Meditation Unhandled hard lock up.

@eried
Copy link

eried commented May 7, 2020

I can confirm tht M4 guru error, awesome! I will buzz around the code to see if I can find the source of the problem

@eried
Copy link

eried commented May 8, 2020

I think I found a way to make it stop hanging :) it needs a call to on_modulation_changed( in the constructor

@fcanaan have you found more bugs? I want to be sure I am not breaking something else before posting the fix

@eried
Copy link

eried commented May 8, 2020

@fcanaan @helmarw take a look and give me feedback of https://github.com/eried/portapack-havoc/releases/download/nightly/portapack-nightly_202005081310.bin It solves the 1/3 screen hang, but not the M4 guru error yet.

@nemanjan00
Copy link

For me, it is hanging if I go to capture, and then, after that into audio reciever

@eried
Copy link

eried commented May 8, 2020

For me, it is hanging if I go to capture, and then, after that into audio reciever

OK you are right, this is a different kind of hang tho. We have 1/3 of screen, M4 guru meditation and "just frozen" now.

I think there is some stuff not cleanly terminated or such, because this #353 is just calling the on_modulation_changed (which calls again the update_modulation ) and it fixes partially some issues. I am doing some test in pocsag and radiosonde constructors/destructors to see if I find the real issue.

@eried
Copy link

eried commented May 8, 2020

OK! so I found the M4 guru meditation problem, SPEC just leaves the sampling rate too high... so this issue would be 100% solved... "And I Would've Gotten Away With It Too. If It Weren't For You Meddling @nemanjan00 ." xDDDDD

@eried
Copy link

eried commented May 8, 2020

@nemanjan00
Copy link

@eried, I did not test that image, but, image built from your master does seem to work without any crashes for me.

@fcanaan
Copy link

fcanaan commented May 8, 2020 via email

@fcanaan
Copy link

fcanaan commented May 9, 2020

Loaded bin. Looking good. Haven't been able to crash it yet. Will keep trying. Thanks!

@fcanaan
Copy link

fcanaan commented May 14, 2020

No crashes in the image yet. I have found that the map does not load when you view a flight picked up by the ads-b app. The worldmap.bin has been generated correctly and is in the correct spot on the sd card. I even reverted to the last public image I had, and the map functionality came back. I went back to the image that doesnt have crashes, but no map.

@eried
Copy link

eried commented May 14, 2020

@fcanaan yes I changed the map file for a mercator one instead of equidistant, you can download my world_map.bin from sdcard.rar or check the pullrequests here to create yours from the updated jpg

@helmarw
Copy link
Author

helmarw commented May 20, 2020

hi, sorry had to take care of other stuff last few weeks. great to see the development, I will try out the updated firmware soon!

@helmarw
Copy link
Author

helmarw commented May 20, 2020

my mistake, havnt tested the older version very much (downloaded and compiled 8th April 2020). it has the same error.
it only happens when Audio is in WFM-mode, switching to TPMS and than back to Audio. that crashes the whole thing
second when i put audio in SPEC-mode and then change to TPMS i get a red screen (M4 GURU Meditation unhandled)... two short videos about that behaviour
crashes.zip

other modes AM and NFM are not influenced either way. I didnt test any other apps, too many possible combination, it just happend that i was using exactly those two configurations for testing my TPMS sensors

GURU still there but Audio doesnt crash anymore, at least not that I could make it

@eried
Copy link

eried commented May 20, 2020

I cannot trigger guru anymore, how are you triggering it?

@helmarw
Copy link
Author

helmarw commented May 20, 2020

im going into Audio and displaying SPEC and then exit Audio and start TPMS

@eried
Copy link

eried commented May 20, 2020

Nope, I fixed that :) it was merged today here or you can check my release bin too

@helmarw
Copy link
Author

helmarw commented May 20, 2020

i recompiled it a aprox 11 hours ago from a fresh git clone
or did you commit something afterwards?

@eried
Copy link

eried commented May 20, 2020

The PR was accepted like 9 hours ago #356, so if you compiled this one 11 hr ago, you still have the guru m4 error

@helmarw
Copy link
Author

helmarw commented May 20, 2020

k makes sense, i was to quick.
i used your nightly built now, and its working
thnx!!! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants