Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): api/users/get-public-profile #54729

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat(api): api/users/get-public-profile #54729

wants to merge 15 commits into from

Conversation

ojeytonwilliams
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams commented May 9, 2024 •
edited

  • test: add some tests for get-public-profile
  • feat: handle missing query and missing users
  • test: add schema test to prevent query use
  • feat: implement responses for locked profile

Checklist:

Post MVP, it would be nice if this just returned what get-session-user returns, but with the private properties null (or omitted). This would both clean up the code and make it clearer what the privacy toggles control.

Closes #54728

@github-actions github-actions bot added the platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. label May 9, 2024
@ojeytonwilliams
refactor: clarify post-mvp goals
146090b
@ojeytonwilliams
fix: separate saveChallenge body from responses
9da9eff 
The body is used for validation and so should care about format,
length and so on.

In contrast the response should not be validated because it would mix
concerns (the handler is under our control and should not produce
invalid output).
@ojeytonwilliams
test: ignore getPublicProfile
9d2b830
@ojeytonwilliams
fix: import of challenge-types
f39f034
@ojeytonwilliams
chore: clean up
7151743
@ojeytonwilliams
refactor: remove private data in separate function
4278798
@ojeytonwilliams ojeytonwilliams marked this pull request as ready for review May 17, 2024 16:12
@ojeytonwilliams ojeytonwilliams requested a review from a team as a code owner May 17, 2024 16:12
@moT01 moT01 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GET /api/users/get-public-profile
2 participants
@ojeytonwilliams @moT01