Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multifile editor - visual indication which editor is for which file #54713

Open
gikf opened this issue May 8, 2024 · 1 comment
Open

Multifile editor - visual indication which editor is for which file #54713

gikf opened this issue May 8, 2024 · 1 comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: UI Threads for addressing UX changes and improvements to user interface status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. type: feature request Threads classified to be feature requests. Implementation to be considered as a nice to have

Comments

@gikf
Copy link
Member

gikf commented May 8, 2024

Is your feature request related to a problem? Please describe.

Multifile editor, as the name suggests, has multiple editors (tabs), each for different file. Each editor can be hidden or shown by their own button, however there isn't really any visual (or text) indication which editor corresponds to which button and therefore to which file.

To be clear, this doesn't seem to create much confusion, if any. I don't recall anybody having issue with mixing up the tabs/editors, both buttons and editors always follow the same ordering.

Nevertheless I think it'd be nice to have a more visible connection between individual buttons and their corresponding editors.

Describe the solution you'd like

The easiest approach might be just including comment at the top of file, similarly to how it's added when creating post on forums via the help button. That doesn't sound ideal though.

Not entirely sure if monaco perhaps has some feature which might be used for this.

Describe alternatives you've considered

Slightly different way to achieve this, might be introducing some additional color for button when corresponding editor is focused.

@gikf gikf added scope: UI Threads for addressing UX changes and improvements to user interface platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. type: feature request Threads classified to be feature requests. Implementation to be considered as a nice to have labels May 8, 2024
@a2937
Copy link
Member

a2937 commented May 14, 2024

I'm actually a pretty huge fan on the additional color when that editor is in focus. But the colors have to distinctive and mesh well with our themes. We do have an purple, a yellow, a blue, and a green we can easily use already defined as accent colors in our style guide. I'm leaning towards purple for html, blue for CSS, and green for Javascript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: UI Threads for addressing UX changes and improvements to user interface status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. type: feature request Threads classified to be feature requests. Implementation to be considered as a nice to have
Projects
None yet
Development

No branches or pull requests

2 participants