Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(curriculum): Updating the assets to be served by the CDN - Music Player Project #54714

Merged
merged 1 commit into from May 13, 2024
Merged

chore(curriculum): Updating the assets to be served by the CDN - Music Player Project #54714

merged 1 commit into from May 13, 2024

Conversation

zxc-w
Copy link
Contributor

@zxc-w zxc-w commented May 8, 2024

Checklist:

Closes #54710

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label May 8, 2024
@jdwilkin4 jdwilkin4 added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. new javascript course These are for issues dealing with the new JS curriculum labels May 10, 2024
@Ksound22
Copy link
Member

@RafaelDavisH, you know better about the images for each video.

At a point, they were different, but I don't remember which point. Could you please provide more insights about this?

JoyShaheb
JoyShaheb approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@JoyShaheb JoyShaheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job locating all the files and updating them!

@JoyShaheb JoyShaheb merged commit 08f63a0 into freeCodeCamp:main May 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoyShaheb JoyShaheb JoyShaheb approved these changes

@jdwilkin4 jdwilkin4 jdwilkin4 approved these changes

Assignees
No one assigned
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update assets for Music player project
4 participants
@zxc-w @Ksound22 @JoyShaheb @jdwilkin4