Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lesson assets should be served by the CDN #54684

Open
3 of 4 tasks
ojeytonwilliams opened this issue May 7, 2024 · 5 comments
Open
3 of 4 tasks

Lesson assets should be served by the CDN #54684

ojeytonwilliams opened this issue May 7, 2024 · 5 comments
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.

Comments

@ojeytonwilliams
Copy link
Contributor

ojeytonwilliams commented May 7, 2024

Describe the bug
We host various curriculum assets on S3.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-basic-string-and-array-methods-by-building-a-music-player/step-5
  2. See links to https://s3.amazonaws.com/org.freecodecamp.mp3-player-project

Expected behavior
They should be hosted on https://cdn.freecodecamp.org/ since S3 is designed to store content, not serve it. By using the CDN the lesson assets can be cached near the learner, resulting in better performance.

Steps to fix

  • search for amazonaws.com in the curriculum/challenges/english folder to find the assets
  • add the assets to https://github.com/freeCodeCamp/cdn
  • update the lessons to use the new assets
  • delete the buckets
@gikf gikf added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label May 7, 2024
@jdwilkin4
Copy link
Contributor

jdwilkin4 commented May 7, 2024

A quick note about the music player.

A couple of years back, I had added some of the songs to the cdn.
But with the revisions to the project, it looks like aws was used instead for the live site.
So, when we do create a PR to move the rest of the songs to the cdn repo, there is already a folder for it here
https://github.com/freeCodeCamp/cdn/tree/main/build/curriculum/js-music-player

@jdwilkin4
Copy link
Contributor

jdwilkin4 commented May 8, 2024

@jdwilkin4
Copy link
Contributor

Hey @ojeytonwilliams !

The last PR for replacing the links in the english curriculum has been merged to main.
So on the next website deployment, all links should be updated in production.

I guess we need to wait for the translations to be updated too.
But I am not sure how that works.

But the english files are set 👍

@ojeytonwilliams
Copy link
Contributor Author

Awesome, thanks @jdwilkin4!

The translations are already live, so it just remains to delete the buckets. I'll take care of that and close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

No branches or pull requests

3 participants