Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(List View): In sidebar filter link field show Title of Field if set #26413

Closed
rareMaxim opened this issue May 11, 2024 · 0 comments · Fixed by #26417
Closed

(List View): In sidebar filter link field show Title of Field if set #26413

rareMaxim opened this issue May 11, 2024 · 0 comments · Fixed by #26417
Labels
feature-request

Comments

@rareMaxim
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In sidebar filter link field show field.name but not field.title

Describe the solution you'd like
if link field has title field - show title.
image
@rareMaxim rareMaxim changed the title In sidebar filter link field show Title of Field if set (List View): In sidebar filter link field show Title of Field if set May 11, 2024
rareMaxim added a commit to rareMaxim/frappe that referenced this issue May 12, 2024
@rareMaxim
feat: In sidebar filter link field show Title of Field if set (frappe…
80fd5a0 
…#26413)
@rareMaxim rareMaxim mentioned this issue May 12, 2024
Merged
akhilnarang added a commit that referenced this issue May 15, 2024
@rareMaxim @akhilnarang
feat: show link field title in sidebar filters if set (#26417)
557293a 
* feat: In sidebar filter link field show Title of Field if set (#26413)

* fix: test_list_view_child_table_filter_with_created_by_filter

* fix tests

* fix: formatting

* fix: formatting

* refactor: cleanup logic slightly, reduce code repetition

Respect value of show_title_field_in_link

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

---------

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: show link field title in sidebar filters if set rareMaxim/frappe
1 participant
@rareMaxim