fix: refactor document.get definition (#26280) #26281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
add-test-cases
casesolved-co-uk
force-pushed
the
doc_get_filters
branch
5 times, most recently
from
1be3e62
to
61feaff
Compare
|
@casesolved-co-uk can you please raise PRs from personal account instead of org forks https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist#maintainer-edits |
ankush
reviewed
May 3, 2024
…nal deprecation warning to the filters keyword fix: doc.get filters arg usage fix: linting fix: customize_form fix: desk and doctype fix: init, doctype, customize, todo, form fix: website fix: change inspect for deprecation_warning
casesolved-co-uk
force-pushed
the
doc_get_filters
branch
from
61feaff
to
fdb2509
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
No This PR is available here: https://github.com/CaseSolvedUK/frappe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: change document.get definition to match dict.get and add positional deprecation warning to the filters keyword
fixes: #26280
Have attempted to fix all core files using the new
filters=argSee also #26279
version-14-hotfix
version-15-hotfix