Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPML import failed #1475

Open
20NE opened this issue Dec 20, 2023 · 2 comments
Open

OPML import failed #1475

20NE opened this issue Dec 20, 2023 · 2 comments
Labels
bug not selfoss

Comments

@20NE
Copy link

20NE commented Dec 20, 2023

selfoss 2.19

OPML file that exported from miniflux, import failed with debug error: Invalid type '': only 'rss' and 'atom' are supported

miniflux opml file like:

<?xml version="1.0" encoding="UTF-8"?>
<opml version="2.0">
    <head>
        <title>Miniflux</title>
        <dateCreated>Wed, 20 Dec 2023 10:28:26 CST</dateCreated>
    </head>
    <body>
        <outline text="All">
            <outline title="http://feeds.feedburner.com/felixcat" text="http://feeds.feedburner.com/felixcat" xmlUrl="http://feeds.feedburner.com/felixcat" htmlUrl="http://feeds.feedburner.com/felixcat"></outline>
            <outline title="https://www.archlinux.org/feeds/news/" text="https://www.archlinux.org/feeds/news/" xmlUrl="https://archlinux.org/feeds/news/" htmlUrl="https://www.archlinux.org/feeds/news/"></outline>
        </outline>
    </body>
</opml>
@jtojnar
Copy link
Member

jtojnar commented Dec 20, 2023

Thanks for reporting. According to the OPML specification, the outline element should contain type="rss" attribute so this is a miniflux bug.

I guess we could consider as feeds even outlines without type attribute, as long as they have xmlUrl. That will allow us to support even applications producing invalid OPML files like this. Though that might cause conflicts if extensions not declared in the main spec also use xmlUrl and the application also omits type. But that is probably rare as, these days, OPML is used for little else than feed exports, and people will usually try to import exports from other feed reader rather than random OPML they find online.

@jtojnar
Copy link
Member

jtojnar commented Dec 20, 2023

I have opened a PR fixing it in miniflux miniflux/v2#2267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug not selfoss
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jtojnar @20NE