Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart invert not consistent #79

Open
jessleenyc opened this issue Oct 29, 2018 · 4 comments
Open

Smart invert not consistent #79

jessleenyc opened this issue Oct 29, 2018 · 4 comments
Labels
accessibility bug bugs; wait for 'approved' label to begin work

Comments

@jessleenyc
Copy link
Contributor

Describe the bug
Submitted by a test user: Smart invert is inverting photos (i.e. profile, cover images)

To Reproduce
Steps to reproduce the behavior:

  1. Go to general -> accessibility -> display accommodations -> smart invert

Expected behavior
I believe photos shouldn't get inverted at all? Or the opposite? Regardless, some are getting inverted and some are not.

Screenshots
image

@jessleenyc jessleenyc added bug bugs; wait for 'approved' label to begin work accessibility labels Oct 29, 2018
@Ceri-anne
Copy link
Contributor

I don't think there's anything we can do to change this as it's Apple trying to be "smart" :)

AFAIK, all we can do is apply accessibilityIgnoresInvertColors = true where we don't want views/imageviews to be inverted

@StriderHND
Copy link
Contributor

I don't think there's anything we can do to change this as it's Apple trying to be "smart" :)

AFAIK, all we can do is apply accessibilityIgnoresInvertColors = true where we don't want views/imageviews to be inverted

This is right also is needed to add a CSS to the images or other media
@media (inverted-colors) { img, video { filter: invert(100); } }

@StriderHND
Copy link
Contributor

I've found a way to inject the CSS via App side when is detecting the smart invert. I should be uploading a PR soon

@larson-carter
Copy link

Should this issue be closed as there was a PR made and it was merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug bugs; wait for 'approved' label to begin work
Projects
None yet
Development

No branches or pull requests

4 participants