Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion on whether link previews should be enabled #184

Open
warpskew opened this issue Oct 15, 2019 · 0 comments
Open

Discussion on whether link previews should be enabled #184

warpskew opened this issue Oct 15, 2019 · 0 comments
Labels
discussion topics open for discussion feature request feature requests; wait for 'approved' label to begin work

Comments

@warpskew
Copy link

I was testing the iOS application on an iPhone 11 Pro Max simulator and noticed that if I press down on a link with 3D Touch (e.g. #javascript under the "Top 100 Tags" section of the app), the system link preview is displayed. Seeing as users should feel like they're having a native experience, I thought It'd be good to open a discussion on this since the link previews allow a user to navigate away from the app into Safari.

To Reproduce

  1. Run app in simulator
  2. Open app
  3. Press down on any post with 3D Touch
  4. Press Open Link option

Expected behavior

I think there may be certain cases where link previews should be supported, but I'm not sure where. I'm not sure if phone numbers or addresses are available in the app, but these may be affected if the link preview feature is turned off.

Screenshots

Simulator Screen Shot - iPhone 11 Pro Max - 2019-10-15 at 15 33 44
Simulator Screen Shot - iPhone 11 Pro Max - 2019-10-15 at 15 33 51

Smartphone (please complete the following information):

  • Device: iPhone 11 Pro Max
  • OS: iOS13.1
  • Version 1.2.1 Build 13

Additional context
There is a property available on web views which disables link previews, but it seems it's a coarse solution: https://developer.apple.com/documentation/webkit/wkwebview/1415000-allowslinkpreview

@jessleenyc jessleenyc added the feature request feature requests; wait for 'approved' label to begin work label Oct 21, 2019
@jessleenyc jessleenyc added discussion topics open for discussion triage labels Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion topics open for discussion feature request feature requests; wait for 'approved' label to begin work
Projects
None yet
Development

No branches or pull requests

2 participants