Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

greenlet fails under python 3.11.8 #659

Open
gmweinberg opened this issue Apr 6, 2024 · 3 comments
Open

greenlet fails under python 3.11.8 #659

gmweinberg opened this issue Apr 6, 2024 · 3 comments

Comments

@gmweinberg
Copy link
Contributor

I am getting an error with pip install -r requirements-dev.txt under python 3.11.8
The error starts out
In file included from src/greenlet/greenlet.c:11:
src/greenlet/greenlet.h:42:5: error: unknown type name ‘CFrame’
42 | CFrame* cframe;
| ^~~~~~
src/greenlet/greenlet.c: In function ‘green_clear_exc’:
src/greenlet/greenlet.c:173:17: error: ‘_PyErr_StackItem’ {aka ‘struct _err_stackitem’} has no member named ‘exc_type’

I was able to make the error go away by removing the version number in requirements.txt, the installation seems to work with greenlet==3.0.3

@gmweinberg
Copy link
Contributor Author

Hmm, I see my pull request is failing under the test system. If I'm reading it correctly, the error is
ImportError: cannot import name 'Celery' from 'celery' (/opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages/celery/init.py)

I admit I only tested under python 3.11 but it seems to me that since 3.7 is past its expiration date it really doesn't need to be supported for new installs. Also, if you'll forgive my naivate, I really don't understand how updating the greenlet version would cause celery to break.

@gordonjcp
Copy link
Contributor

I can't disagree. If you can come up with a PR that removes dead versions of Python too that'd be awesome :-)

@gmweinberg
Copy link
Contributor Author

I'll give it a shot. It looks like I just need to change .github/workflows/tests.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants